fn sync_get will check if it is initialized, acquire and return the value
fn is_initialized will only check if it is initialized, without synchronizing.
This is the only change I would need to the sync module to be able to add an experimental implementation using consume. Do you think it makes sense on its own? And is the change small enough not to bother duplicating the sync module?
The last commit is optional. It seems nice if initialize would return value. This prevents an unnessecary unwrap in get_or_try_init, for which the code used an unsafe get_unchecked before to prevent.
This is based on top of https://github.com/matklad/once_cell/pull/72, only the last two commits are relevant.
Before using
MaybeUninitthere were two ways to check whether aOnceCellwas initialized:is_initialized, which had the side effect of acquiring the value.Some, which didn't do any synchronization.After https://github.com/matklad/once_cell/pull/72 we just always call
is_initialized. I would like to bring back the distinction:fn sync_getwill check if it is initialized, acquire and return the valuefn is_initializedwill only check if it is initialized, without synchronizing.This is the only change I would need to the
syncmodule to be able to add an experimental implementation using consume. Do you think it makes sense on its own? And is the change small enough not to bother duplicating thesyncmodule?The last commit is optional. It seems nice if
initializewould returnvalue. This prevents an unnessecaryunwrapinget_or_try_init, for which the code used an unsafeget_uncheckedbefore to prevent.