Perceptually uniform colourscheme

matklad / pale-fire

Port of Emacs Zenburn theme to VS Code

https://marketplace.visualstudio.com/items?itemName=matklad.pale-fire

72 stars 7 forks source link

Perceptually uniform colourscheme #24

Closed lunacookies closed 3 years ago

lunacookies commented 3 years ago

This fixes #19.

I finally did it!

Here’s the before and after, showing how little has changed:

before:

after:

Hard to tell the difference, isn’t it?

I think a good demonstration of how easy it has now become to change the theme is in commit 959b2ae; in it I slightly darken the foreground text of the status bar, including across different modes where the foreground colour changes, by changing a single number.

I’d say this PR is less about the actual change it’s making, but more about the flexibility it gives us to change the theme.

matklad commented 3 years ago

Let's bump the version in package.json?

lgtm!

lunacookies commented 3 years ago

Let's bump the version in package.json?

Do you think this warrants a bump to 0.3? 😄

lgtm!

I’ve been waiting to do this for so long! I’m really happy that I finally got around to doing this, I can’t stop smiling :)

matklad commented 3 years ago

Do you think this warrants a bump to 0.3? smile

yup!

matklad commented 3 years ago

Could you also add sample.rs and an updated screenshot? I've been thinking about the "withing" typo for like half a year already )

lunacookies commented 3 years ago

Could you also add sample.rs and an updated screenshot? I've been thinking about the "withing" typo for like half a year already )

I was thinking that, since it’s so easy to change the colours now, it might be worth going through and tweaking all the colours. I’ve tried to keep the colours as close as possible in this PR (as you can tell from the screenshots), but I’ve had a few ideas for things that might be worth changing.