search

matklad / xshell

Apache License 2.0
677 stars 28 forks source link

`ignore_status` should take a boolean argument #41

Closed matklad closed 2 years ago

matklad commented 2 years ago

We should spell it as .ignore_status(true), to match .echo_cmd() and in general to be a friendlier API. Sadly, that would be a breaking change.

azdavis commented 2 years ago

We do have set_ignore_status: https://github.com/matklad/xshell/blob/11ab785e5a78b1c35eadceca35848dac6a494843/src/lib.rs#L877-L880