v0.2

[matklad]

This is a significant rewrite of xshell. The main change is the switch from global-state API to object based API -- Shell is now a thing and is the gateway to all API.

Motivation is manyfold:

• Curren fs API is unergonomic, as it requires importing many individual functions. With the new style API, use xshell::{Shell, cmd}; is all you need, and API is discoverable via sh. auto-completion.
• Soundness. The recent discussion on IRLO https://internals.rust-lang.org/t/synchronized-ffi-access-to-posix-environment-variable-functions/15475 convinced me that process' environment shold be read-only
• Implementation complexity: we spend a lot of effort debugging various issues related to gsl.

Specific changes:

• There's now a Shell which holds the environment. For ergonomics reasons, Shell uses interior mutability.
• The cmd! macro now requires a Shell as a first argument.
• The Cmd builder methods are somewhat more orthogonal.
• The suggested naming no longer follows UNIXism which makes the naming more incluiseve and natural (assuming you have code completion).

With the present API, I also feel we should shift from "convenient hacks" to "robust tool". As a first step to that end, stdin is now fed via a dedicated thread, to aviod deadlock.

This is mostly done I think, but I at least need to check this on windows as well.

[matklad]

Thanks for the review @azdavis!

Whats your overall feeling on the direction this is going in?

[ngirard]

(I'm just passing by, but I wanted to say: it's a damn good job guys! Keep going !)

[azdavis]

I like less global state, and renaming the fs functions to be more searchable is good too!

[matklad]

bors r+

[bors[bot]]

Build succeeded:

• publish