matklad / xshell

Apache License 2.0
696 stars 30 forks source link

Emit more informative error message when cwd does not exist #73

Closed smoelius closed 1 year ago

smoelius commented 1 year ago

Fixes #72 in the manner described in https://github.com/matklad/xshell/issues/72#issuecomment-1627735581.

Nits are welcome.

matklad commented 1 year ago

yup!

matklad commented 1 year ago

bors r+

matklad commented 1 year ago

bors retry

bors[bot] commented 1 year ago

Already running a review

matklad commented 1 year ago

bors r-

bors[bot] commented 1 year ago

Canceled.

matklad commented 1 year ago

bors r+

smoelius commented 1 year ago

~Want me to rebase?~ (I think I'm too late.)

matklad commented 1 year ago

No need to rebase, bors shold do the right thing here.

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

matklad commented 1 year ago

should be published as 0.2.4 if I didn't mess up my new scoped token:

https://github.com/matklad/xshell/pull/74

smoelius commented 1 year ago

Thanks!