search

matkoch / resharper-fluentassertions

MIT License
13 stars 2 forks source link

Add simple NUnit assertions for booleans and Null #13

Closed mu88 closed 2 years ago

mu88 commented 2 years ago

@inyutin-maxim Thank you for your amazing job! Due to your fundamentals, adding these simple assertions was super easy 👏🏻

inyutin-maxim commented 2 years ago

I think be cool add a test cases. You can add to folder /src/dotnet/ReSharperPlugin.FluentAssertions.Tests/test/data/NUnitAssertMigrationQuickFixTests/ files:

etc

mu88 commented 2 years ago

Honestly, I didn't really understand your test name pattern, but I hope that's what you're looking for :)

How can I execute the tests? When simply running them in Rider, each and every test fails with No build requested on commandline.
If the tests can be run from the CLI, I'd like to setup a build pipeline as I did it already here

inyutin-maxim commented 2 years ago

Honestly, I didn't really understand your test name pattern, but I hope that's what you're looking for :)

How can I execute the tests? When simply running them in Rider, each and every test fails with No build requested on commandline. If the tests can be run from the CLI, I'd like to setup a build pipeline as I did it already here

You got the test naming pattern right. I have all tests running correctly on Windows 11. Under Kubuntu 21.10, I could not run the tests they also fall. I think I misconfigured the environment, maybe we could help with this @matkoch

mu88 commented 2 years ago

And did you have to install/configure something to run the tests or can you simply run dotnet test on your machine and it works? I have never seen these gold files before...

inyutin-maxim commented 2 years ago

And did you have to install/configure something to run the tests or can you simply run dotnet test on your machine and it works?

On my Windows station i install only dotnet core 6 sdk and all works fine. For linux environment i install Mono sdk, dotnet core 6 sdk but all tests failed.

I have never seen these gold files before...

*.gold file - this expected result snapshot after quickfix

mu88 commented 2 years ago

Ah, I forgot to update Plugin.props, now it looks "better" - I'm getting a NuGet restore error, but that's probably because of the corporate proxy I'm behind - at least four tests are running now, I'll try the others later at home.

@inyutin-maxim is the code base in this PR fine for you so that @matkoch could do the merge?

inyutin-maxim commented 2 years ago

@inyutin-maxim is the code base in this PR fine for you so that @matkoch could do the merge?

Yes, of course, it looks good to me