matkoch / resharper-verify

23 stars 4 forks source link

Throw Exception When Launching Diff Fails #13

Closed BrunoJuchli closed 1 year ago

BrunoJuchli commented 2 years ago

DiffRunner.Launch returns an error when it fails to actually show the diff, but this error is currently being swallowed. With this PR I attempt to remedy this:

Results DiffRunner.Launch are recorded, classified as either error or success, and an exception is thrown if any launch attempt fails. The error message contains the file path and result (enum value name).

I suspect there may be a better way to report such errors to ReSharper/Rider, but I'm completely unfamiliar with ReSharper/Rider plugin development. So maybe @matkoch could improve on this PR?