matkoch / resharper-verify

22 stars 4 forks source link

Rider "Verify Support" plugin buttons does nothing #5

Closed zlepper closed 2 years ago

zlepper commented 2 years ago

This is an almost straight copy from here: https://github.com/VerifyTests/Verify/issues/452

Describe the bug

I'm using Verify to test a source generator. The test itself runs fine and has the expected output. However, trying to use the "Accept received" and "Compare Accepted/Receives" buttons does nothing. As in nothing happens when I click those buttons. I have ensured that tests are allowed to start sub-processes. When the test fails a diff tool does start, so Rider can clearly be found by Verify.

Logs from Rider, where I only started the IDE, found a failing test and clicked those buttons. rider verify logs.zip

And video in case my rambling didn't make any sense:

https://user-images.githubusercontent.com/1499810/147223348-8945bd14-0f98-42ea-989e-4f57801441d4.mp4

Minimal Repro

Here is a somewhat minimal solution that has a source generator and everything. The buttons still don't work. VerifyBug.zip

Rider version:

JetBrains Rider 2021.3.1
Build #RD-213.5744.299, built on December 8, 2021
Licensed to Rasmus Hjelmberg Hansen
Subscription is active until September 19, 2022.
Runtime version: 11.0.13+7-b1751.19 amd64
VM: Dynamic Code Evolution 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
.NET Framework 4.0.30319.42000
GC: G1 Young Generation, G1 Old Generation
Memory: 8192M
Cores: 12
Registry:
    ide.mac.bigsur.window.with.tabs.enabled=false
    rdclient.asyncActions=false
    indexing.enable.entity.provider.based.indexing=false
    ide.new.project.model.index.case.sensitivity=true

Non-Bundled Plugins:
    verify-rider (2021.3.0)
    org.antlr.intellij.plugin (1.17)
    idea.plugin.protoeditor (213.5744.224)
    com.intellij.resharper.StructuredLogging (2021.3.0.177)
    com.intellij.resharper.HeapAllocationsViewer (2021.3.0)
    com.intellij.ideolog (203.0.27.0)
    com.intellij.plugin.adernov.powershell (2.0.9)

Verify Support plugin version: 2021.3.0

lars-erik commented 2 years ago

We have the same issue on a freshly installed mac with Rider. (all newest versions) Neither Verify.NUnit nor the Verify plugin pops any diff. (Nor does the approve command work) For now we're working around it using command-D to diff the files.

SimonCropp commented 2 years ago

this will be fixed in the next release via https://github.com/matkoch/resharper-verify/commit/137bad320cfaa4e6de9c3ac146be175c31f44ccb

milkshakeuk commented 2 years ago

This still seems to be broken for me, latest rider and plugin windows 11. VerifyExample2

matkoch commented 2 years ago

@milkshakeuk can we please communicate through one issue? I already mentioned what's needed to troubleshoot this: https://github.com/matkoch/resharper-verify/issues/8#issuecomment-1049229566

milkshakeuk commented 2 years ago

@matkoch yes using the original issue now, sorry.

SimonCropp commented 2 years ago

can u try 2022.1.0