matkoniecz / lunar_assembler

SVG maps from OpenStreetMap data. Available at https://mapsaregreat.com/osm_to_svg_in_browser/
GNU Affero General Public License v3.0
40 stars 5 forks source link

short footway=crossing, shorter than guessed road width are causing issues #106

Open Zaneo opened 3 years ago

Zaneo commented 3 years ago

https://www.openstreetmap.org/way/561900089 and touching crossing ways is/are unexpectedly crossing with road area not exactly two times (or even even count) but 0 times, which is unhandled something went wrong. If OpenStreetMap data is correct here, then this is a bug, please report to https://github.com/matkoniecz/lunar_assembler/issues

From what I can see the OpenStreetMap data looks reasonable?

matkoniecz commented 3 years ago

Thanks for report! Yes, OSM data seem fine here.

Do you remember which map style you used? (I should include it in an error message)

matkoniecz commented 3 years ago

Though https://www.openstreetmap.org/way/197017783 seems quite narrow on aerial view - is it maybe a service road rather than unclassified? Maybe even alley or driveway?

Zaneo commented 3 years ago

I'll go take a picture of the road later. It's likely not an alley. Japan has lots of "two lane" narrow roads. Could be residential whatever that means.

Zaneo commented 3 years ago

Thanks for report! Yes, OSM data seem fine here.

Do you remember which map style you used? (I should include it in an error message)

I didn't change the default settings.

matkoniecz commented 3 years ago

https://mapsaregreat.com/osm_to_svg_in_browser/laser_neighbourhood?rerun_query=yes&bounds={%22west%22%3A139.7282188385725%2C%22south%22%3A35.59073753752561%2C%22east%22%3A139.72849778831005%2C%22north%22%3A35.590916392329014} fails

https://mapsaregreat.com/osm_to_svg_in_browser/general_high_zoom?rerun_query=yes&bounds=%7B%22west%22%3A139.7282188385725%2C%22south%22%3A35.59073753752561%2C%22east%22%3A139.72849778831005%2C%22north%22%3A35.590916392329014%7D works

matkoniecz commented 3 years ago

So there are two parts here

1) stop crashing and generate something 2) produce nice crossing also in such case (by extending such line and making it longer)

Zaneo commented 3 years ago

https://www.mapillary.com/app/user/Zaneo?lat=35.590917100232&lng=139.72808514735&z=17&pKey=349773063548485&focus=photo

Here's that area for reference.