matkoniecz / lunar_assembler

SVG maps from OpenStreetMap data. Available at https://mapsaregreat.com/osm_to_svg_in_browser/
GNU Affero General Public License v3.0
40 stars 5 forks source link

Problem with vertical rectangle #25

Closed frydrycht closed 3 years ago

frydrycht commented 3 years ago

When user selects rectangle which is "vertical" the tool generates "horizontal" rectangle only with objects contained in selected area. Because of this some objects are missing in generated file. osm mapa

matkoniecz commented 3 years ago

OK, I will look into it. It should leave empty margins on left/right and show entire vertical area (as clipping is missing - #22 - it will show objects on marging).

matkoniecz commented 3 years ago

@frydrycht Can you post screenshot showing entire area, with "download SVG" button in view? You may need to zoom out view a bit. Or scroll down.

It seems to me that it is working correctly - see:

screen12

frydrycht commented 3 years ago

If there is a problem with clipping my issue is not valid any more. Telling "missing objects" I thought about objects which are out of the selected area but in area generated on SVG file.

matkoniecz commented 3 years ago

In such case it is the same as #22 - it is a known issue that will be fixed

matkoniecz commented 3 years ago

I just fixed #22 so this effect should disappear :)