MATLAB Cache fixes - Githubissues

matlab-actions / setup-matlab

Set up your GitHub Actions workflow with a specific version of MATLAB.

BSD 3-Clause "New" or "Revised" License

75 stars 9 forks source link

Closed davidbuzinski closed 5 months ago

davidbuzinski commented 5 months ago

This PR addresses 2 issues:

Warn instead of hard error if GitHub Actions cache is unavailable: https://github.com/matlab-actions/setup-matlab/issues/98
Fix unclear errors for macOS and Windows if user uses actions/cache action: https://github.com/matlab-actions/setup-matlab/issues/93

davidbuzinski commented 5 months ago

I made a few more changes:

In our Windows workaround I added the restore for tool cache into a try-finally block because if steps were failing we were leaving the tool cache as the wrong directory
If windows is not detected in the cache as completed due to missing .complete file or some other reason, we were getting problems with the symlinks against a partially completed install
add awaits for io.rmRF because I was seeing some weird control flow errors