search

matlab-actions / setup-matlab

Set up your GitHub Actions workflow with a specific version of MATLAB.
BSD 3-Clause "New" or "Revised" License
76 stars 10 forks source link

Document the use of 'latest' as release parameter - v2-beta #85

Closed pauldruce closed 8 months ago

pauldruce commented 9 months ago

I noticed that in the action definition: https://github.com/matlab-actions/setup-matlab/blob/v2-beta/action.yml the default value for the 'release' input is 'latest'. However, this is not documented anywhere in the README.

The desired use case is to run a workflow using an older version of MATLAB such as R2020b, and the latest available MATLAB. Currently, using the documentation https://github.com/matlab-actions/setup-matlab/tree/v2-beta#set-up-matlab doesn't mention you can pass in the string 'latest' to get the latest.

I should mention this is in the v2-beta for the setup-matlab action.

mcafaro commented 9 months ago

Good point. We will update the documentation to make this more clear.

VisLab commented 9 months ago

I'm not sure whether this update will fix my problem, but GitHub is no longer supporting node16 and so the command and test actions are failing.

mcafaro commented 9 months ago

@VisLab We are working on the transition to Node 20. I would not expect the actions to fail with Node 16. Can you point to a job experiencing the issue?

VisLab commented 9 months ago

I've tried a number of unsuccessful variations and maybe I am failing to run correctly.

For example in: https://github.com/hed-standard/hed-matlab/actions/runs/7701527204/job/20987764939 which is my latest try, I tried the run-command option. The Yaml file is:

https://github.com/hed-standard/hed-matlab/blob/main/.github/workflows/ci.yaml

The runAllTests in the tests directory successfully runs all tests locally. Thx!

On Mon, Jan 29, 2024 at 3:47 PM Mark Cafaro @.***> wrote:

@VisLab https://github.com/VisLab We are working on the transition to Node 20. I would not expect the GitHub Actions to fail with Node 16. Can you point to a job experiencing the issue?

— Reply to this email directly, view it on GitHub https://github.com/matlab-actions/setup-matlab/issues/85#issuecomment-1915630183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJCJOTT7FKXGB23SEAAZBTYRAKHZAVCNFSM6AAAAABCI3AZC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVGYZTAMJYGM . You are receiving this because you were mentioned.Message ID: @.***>

mcafaro commented 9 months ago

@VisLab It looks like the command is missing a closing parenthesis after the addpath(genpath("tests").

The command is currently: addpath(genpath("hedcode")), addpath(genpath("tests"), runAllTests

But should be: addpath(genpath("hedcode")), addpath(genpath("tests")), runAllTests

Can you try adding the closing parenthesis to see if that resolves the issue?

VisLab commented 9 months ago

Thanks much --- that fixed the problem.

On Mon, Jan 29, 2024 at 4:37 PM Mark Cafaro @.***> wrote:

@VisLab https://github.com/VisLab It looks like the command is missing a closing parenthesis after the addpath(genpath("tests").

The command is currently: addpath(genpath("hedcode")), addpath(genpath("tests"), runAllTests

But should be: addpath(genpath("hedcode")), addpath(genpath("tests")), runAllTests

Can you try adding the closing parenthesis and see if that resolves the issue.

— Reply to this email directly, view it on GitHub https://github.com/matlab-actions/setup-matlab/issues/85#issuecomment-1915696201, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJCJOQVV2A4BPCAWTYYAJLYRAQAZAVCNFSM6AAAAABCI3AZC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVGY4TMMRQGE . You are receiving this because you were mentioned.Message ID: @.***>

mcafaro commented 8 months ago

https://github.com/marketplace/actions/setup-matlab now documents and shows an example of release: latest