matllubos / mimeparse

Automatically exported from code.google.com/p/mimeparse
MIT License
0 stars 0 forks source link

split() is deprecated in PHP >= 5.3 #13

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install PHP 5.3

What is the expected output? What do you see instead?

No warnings. Since parse_mime_type() method is not using split() for regex, 
explode() is a suitable replacement.

What version of the product are you using? On what operating system?

trunk, revision 22

Please provide any additional information below.

http://us3.php.net/manual/en/function.split.php
http://us3.php.net/manual/en/function.explode.php

"Works for me" patch attached. Test result below.

php mimeparse.php
application/xml;q=1 - OK
application/xml - OK
application/xml;q= - OK
application/xml ; q=1;b=other - OK
application/xml ; q=2;b=other - OK
 *; q=.2 - OK
text/html;level=1 - OK
text/html - OK
text/plain - OK
image/jpeg - OK
text/html;level=2 - OK
text/html;level=3 - OK
application/xbel+xml - OK
application/xbel+xml; q=1 - OK
application/xml; q=1 - OK
application/*; q=1 - OK
* / * - OK
text/ *;q=0.5,* / *;q=0.1 - OK
text/html,application/atom+xml; q=0.9 - OK
application/json, text/javascript, */* - OK
application/json, text/html;q=0.9 - OK
image/png - OK
image/* - OK

Original issue reported on code.google.com by mradcli...@gmail.com on 9 Nov 2011 at 8:16

Attachments: