matloff / qeML

40 stars 14 forks source link

Error generated #12

Open ggrothendieck opened 10 months ago

ggrothendieck commented 10 months ago

This gives the error shown.

library(qeML)
set.seed(123)
ix <- sample(10, 15, replace = TRUE) + seq(1, 150, 10) - 1
iris.ix <- iris[ix, 1:4]
qeKNN(iris.ix, "Petal.Length", k = 1)
## Error in `[.data.frame`(tst, , ycol) : undefined columns selected

Note that this works without error:

library(qeML)
set.seed(123)
qeKNN(iris[1:4], "Petal.Length", k = 1)
# ...snip...

and this too:

library(FNN)
set.seed(123)
ix <- sample(10, 15, replace = TRUE) + seq(1, 150, 10) - 1
iris.ix <- iris[ix, 1:4]
knn.reg(iris.ix[-4], y = iris.ix[[4]], k = 1)
## PRESS =  0.44 
## R2-Predict =  0.9511979 
matloff commented 10 months ago

Yes, fixed in Version 1.2.

On Mon, Jan 8, 2024 at 11:47 AM ggrothendieck @.***> wrote:

This gives the error shown.

library(qeML) set.seed(123) ix <- sample(10, 15, replace = TRUE) + seq(1, 150, 10) - 1 iris.ix <- iris[ix, 1:4] qeKNN(iris.ix, "Petal.Length", k = 1)

Error in [.data.frame(tst, , ycol) : undefined columns selected

Note that this works without error:

library(qeML) set.seed(123) qeKNN(iris[1:4], "Petal.Length", k = 1)

...snip...

and this too:

library(FNN) set.seed(123) ix <- sample(10, 15, replace = TRUE) + seq(1, 150, 10) - 1 iris.ix <- iris[ix, 1:4] knn.reg(iris.ix[-4], y = iris.ix[[4]], k = 1)

PRESS = 0.44

R2-Predict = 0.9511979

— Reply to this email directly, view it on GitHub https://github.com/matloff/qeML/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ34ZN6RYZU54PQJ7RPML3YNRENVAVCNFSM6AAAAABBR7KG72VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TCMJRGUYTEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>