Missing detection for Samsung EG-2152 feature phone

matomo-org / device-detector

The Universal Device Detection library will parse any User Agent and detect the browser, operating system, device used (desktop, tablet, mobile, tv, cars, console, etc.), brand and model.

http://devicedetector.net

GNU Lesser General Public License v3.0

3.16k stars 483 forks source link

Missing detection for Samsung EG-2152 feature phone #5327

Closed matisojka closed 9 years ago

matisojka commented 9 years ago

User agent: SAMSUNG-GT-E2152/E2152XXJK2 NetFront/3.5 Profile/MIDP-2.0 Configuration/CLDC-1.1 Phone details: http://www.gsmarena.com/samsung_e2152-3448.php

My proposed values:

Client name: NetFront 3.5 Client full version: 3.5 OS name: Samsung GT-E2152 OS full version: GT-E2152 Device brand: Samsung Device type: feature phone

What would be the best strategy for adding this phone?

sgiehl commented 9 years ago

Currently that useragent is detected as:

user_agent: SAMSUNG-GT-E2152/E2152XXJK2 NetFront/3.5 Profile/MIDP-2.0 Configuration/CLDC-1.1
os: [ ]
client:
  type: browser
  name: NetFront
  short_name: NF
  version: 3.5
  engine: NetFront
device:
  type: smartphone
  brand: SA
  model: GT-E2152
os_family: Unknown
browser_family: NetFront

Client ist correct. Device is detected, but it should be a feature phone instead of smartphone. I'll fix that.