search

matomo-org / device-detector

The Universal Device Detection library will parse any User Agent and detect the browser, operating system, device used (desktop, tablet, mobile, tv, cars, console, etc.), brand and model.
http://devicedetector.net
GNU Lesser General Public License v3.0
2.91k stars 473 forks source link

Liebao and CM Browser are probably the same #6056

Open Findus23 opened 4 years ago

Findus23 commented 4 years ago

When updating the icons, I noticed that I already had an icon for a Cheetah Mobile browser. I don't exactly know what Liebao is, but the website is mentioned here: https://en.wikipedia.org/wiki/CM_Browser And on the website I can also see the CM logo.

So I think these are just different names for similar projects. Should I just use the same icon for both, or should we merge them in Device Detector?

mimmi20 commented 4 years ago

Kingsoft, the creator of Liebao, is since a merger in 2010 the parent company of Cheetah Mobile, the creator of the CM Browser. Maybe Liebao is an old name of the CM Browser. see here

sgiehl commented 4 years ago

Thanks @Findus23 for pointing that out. Will remove Liebao in favor of CM Browser

mimmi20 commented 4 years ago

@sgiehl If you do that, you should remove the other browsers, that changed their name, too (like CoolNovo/ChromePlus or Phoenix/Firebird/Firefox). I'm sure there are more.

sgiehl commented 4 years ago

@mimmi20 I searched a bit. And it seems Liebao is/was another name for Cheetah Browser. See https://malwaretips.com/threads/liebao-cheetah-browser.38194/ The Mobile version of that browser seems to be the CM Browser. As Cheetah is still downloadable I will simply change it to that name

sgiehl commented 4 years ago

@Findus23 guess you can then simply use the same icon for Cheetah Browser and CM Browser.

Findus23 commented 4 years ago

I just noticed that the same is true for the LieBaoFast browser. (I can't find anything about this variant on the internet)

https://github.com/matomo-org/device-detector/blob/75cbd494bc6f5e50747f4fbc2e6696cc6abd5398/Parser/Client/Browser.php#L133

liviuconcioiu commented 4 years ago

I want to give an update on LieBao/Cheetah issue. What I did:

  1. I entered on Google Translate, LieBao, which Google detected as Chinese, and it translated to Cheetah. So the conclusion is that they use different marketing names for Chinese / International.
  2. I have installed both desktop versions I could find on https://www.liebao.cn/. The previous version is based on Chrome 57 and the latest on Chrome 63. 
    Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36 LBBROWSER
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.26 Safari/537.36 Core/1.63.5977.400 LBBROWSER/10.1.3752.400
  3. I have installed the mobile version, called CM Browser from Play Store, and the user-agent is: Mozilla/5.0 (Linux; Android 6.0; Zun X Build/MRA58K; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/44.0.2403.119 Mobile Safari/537.36 ACHEETAHI/1
  4. Icon is the same for all browsers.

All 3 user-agents are detected, but I have a few improvement ideas:

  1. Desktop versions are both called Cheetah Security Browser (changelog here http://bbs.duba.net/thread-4191272467-1-1.html and the filename is KSbrowser_home_2019051001.exe, S comes from Security). A rename from Cheetah Browser to Cheetah Security Browser should be done.
  2. LBBROWSER should only have deviceName set to desktop, regarding of what other fragments of the user-agent might say.
  3. ACHEETAHI should have deviceName set to smartphone, if the other fragments can't return this. CE should be added to $mobileOnlyBrowsers list.
  4. Since both versions are based on Chrome, LB and CE should be added to $browserFamilies['Chrome'].

Regarding LieBao Fast icon:

I have searched for LieBao Fast on baidu.com and this is the second result, http://m.liebao.cn/fast/fe/welcome/page.html. Sadly the page is broken. What I think is that LieBao Fast was a light previous version of CM Browser. My suggestion is to add the same icon of CM Browser.