search

matomo-org / device-detector

The Universal Device Detection library will parse any User Agent and detect the browser, operating system, device used (desktop, tablet, mobile, tv, cars, console, etc.), brand and model.
http://devicedetector.net
GNU Lesser General Public License v3.0
2.93k stars 474 forks source link

New device types #6089

Closed liviuconcioiu closed 2 years ago

liviuconcioiu commented 4 years ago

I'm looking to add a few more device types, but before I do this I want to know if the new types are okay.

DEVICE_TYPE_WEARABLE will include watches and headsets, or should I make different device types? DEVICE_TYPE_APPLIANCE will include refrigerators (I have 1 user agent so far) DEVICE_TYPE_PRINTER will include printers DEVICE_TYPE_SIGNAGE will include signages

Findus23 commented 4 years ago

Hi,

I think the first three should be pretty straightforward to convey to people with just a word and an icon. But I'm not so sure about Signage. Do you have an example device?

liviuconcioiu commented 4 years ago 
BrightSign/4.6.46 (XD230) Mozilla/5.0 (compatible; Linux mips) AppleWebKit/537.4 (KHTML, like Gecko) Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/537.4
BrightSign/5.1.52 (SV-4K-ROW) Mozilla/5.0 (compatible; Linux mips) AppleWebKit/537.4 (KHTML, like Gecko) Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/537.4
sgiehl commented 4 years ago

@liviuconcioiu I think those useragents are from products from https://www.brightsign.biz Seem to be some media players, video decoders and stuff like that.

liviuconcioiu commented 4 years ago

There are media players, specially designed for digital signs https://web.archive.org/web/20140225051220/http://www.brightsign.biz/files/9613/4761/4892/HD2000PressRelease.pdf and https://github.com/smart-ecommerce/prestashop/blob/master/creditagricolepaymentgateway/vendor/whichbrowser/parser/tests/data/signage/other.yaml

So how should we classify them? Media players?

sanchezzzhak commented 2 years ago

is this issue still relevant?

sgiehl commented 2 years ago

Guess we can close it. If we need new device types again, we can discuss that in a new issue or PR at any time.