search

matomo-org / device-detector

The Universal Device Detection library will parse any User Agent and detect the browser, operating system, device used (desktop, tablet, mobile, tv, cars, console, etc.), brand and model.
http://devicedetector.net
GNU Lesser General Public License v3.0
2.89k stars 470 forks source link

Chrome as browser family #7488

Open Simbiat opened 10 months ago

Simbiat commented 10 months ago

$browserFamilies variable has this family in it:

'Chrome' => [
'1B', '2B', '7S', 'A0', 'AC', 'A4', 'AE', 'AH', 'AI',
'AO', 'AS', 'BA', 'BM', 'BR', 'C2', 'C3', 'C5', 'C4',
'C6', 'CC', 'CD', 'CE', 'CF', 'CG', 'CH', 'CI', 'CL',
'CM', 'CN', 'CP', 'CR', 'CV', 'CW', 'DA', 'DD', 'DG',
'DR', 'EC', 'EE', 'EU', 'EW', 'FA', 'FS', 'GB', 'GI',
'H2', 'HA', 'HE', 'HH', 'HS', 'I3', 'IR', 'JB', 'KN',
'KW', 'LF', 'LL', 'LO', 'M1', 'MA', 'MD', 'MR', 'MS',
'MT', 'MZ', 'NM', 'NR', 'O0', 'O2', 'O3', 'OC', 'PB',
'PT', 'QU', 'QW', 'RM', 'S4', 'S6', 'S8', 'S9', 'SB',
'SG', 'SS', 'SU', 'SV', 'SW', 'SY', 'SZ', 'T1', 'TA',
'TB', 'TG', 'TR', 'TS', 'TU', 'TV', 'UB', 'UR', 'VE',
'VG', 'VI', 'VM', 'WP', 'WH', 'XV', 'YJ', 'YN', 'FH',
'B1', 'BO', 'HB', 'PC', 'LA', 'LT', 'PD', 'HR', 'HU',
'HP', 'IO', 'TP', 'CJ', 'HQ', 'HI', 'PN', 'BW', 'YO',
'DC', 'G8', 'DT', 'AP', 'AK', 'UI', 'SD', 'VN', '4S',
'2S', 'RF', 'LR', 'SQ', 'BV', 'L1', 'F0', 'KS', 'V0',
'C8', 'AZ', 'MM', 'BT', 'N0', 'P0', 'F3', 'VS', 'DU',
'D0', 'P1', 'O4', '8S', 'H3', 'TE', 'WB', 'K1', 'P2',
'XO', 'U0', 'B0', 'VA', 'X0', 'NX', 'O5', 'R1', 'I1',
'HO', 'A5', 'X1', '18', 'B5', 'B6', 'TC', 'A6', '2X',
'F4', 'YG', 'WR', 'NA', 'DM', '1M', 'A7', 'XN', 'XT',
'XB', 'W1', 'HT', 'B8', 'F5', 'B9', 'WA', 'T0', 'HC',
'O6', 'P7', 'LJ', 'LC', 'O7', 'N2', 'A8', 'P8',
],

Should not this be Chromium, since Chrome is a specific clsoed-code browser, while Chromium is the open-source browser, which is used by all those other browsers.

I am fine with creating PR for correction, but I think this warrants proper discussion first.

sgiehl commented 10 months ago

I agree that Chromium would be the correct family name. But as renaming that might break applications using this library I'm unsure if it's worth the change. If we decide changing it, we need to ensure this will be included in a new major release only.

Simbiat commented 10 months ago

What would constitute major release, though? If I prepare PR for this one, #7487, #7489 (with some stricter classifications in comments for future additions), #7491 (that is potentially moving some bots to apps), and also some brand updates (I am in progress of collecting logos for them, and have already noticed some discrepancies) - would that be a big enough collection of changes?

sgiehl commented 10 months ago

Sure. We can do a major release any time. This was more a general note, that such changes can't go into path or minor release, to not break up things for anyone.