matomo-org / device-detector

The Universal Device Detection library will parse any User Agent and detect the browser, operating system, device used (desktop, tablet, mobile, tv, cars, console, etc.), brand and model.
http://devicedetector.net
GNU Lesser General Public License v3.0
2.96k stars 476 forks source link

Duplicate Foobar2000 media player #7918

Closed jrfavre closed 1 week ago

jrfavre commented 1 week ago

Hello,

It seems Foorbar2000 is duplicated in regexes/client/mediaplayers.yml.

On line 40 :

On line 116:

In Tests/fixtures/mediaplayer.yml, i have only found :

user_agent: foobar2000/1.6.1 os: [ ] client: type: mediaplayer name: Foobar2000 version: 1.6.1 device: type: "" brand: "" model: "" os_family: Unknown browser_family: Unknown

Do you think the regex on line 116 can be safely removed ?