search

matomo-org / github-action-tests

tests package for github action
3 stars 5 forks source link

plugin builds do not copy hidden files to /path/to/matomo/plugins/$PLUGIN_NAME #13

Open diosmosis opened 7 months ago

diosmosis commented 7 months ago

Plugin files like matomo/plugins/MyPlugin/.hidden do not get copied into the cloned Matomo in https://github.com/matomo-org/github-action-tests/blob/main/scripts/bash/checkout_matomo.sh#L15.

They should be copied, as they might be or may become necessary for automated tests.

(In my case, the file is named .wp-env.json and is needed for a new test.)

michalkleiner commented 7 months ago

Yep, that's probably a sensible thing to do. We can add shopt -s dotglob to the script.

sgiehl commented 7 months ago

@diosmosis Feel free to create a PR with the changes if this is needed.