Closed username1290 closed 6 years ago
Hi, Many thanks for adding a new icon. 🎉 Just a few notes (as I haven't had time to write down how exactly I am structuring everything):
square
is just a rule of thumb, as my converter script cuts all white space away and then places the icon on a square👍
On Sun, Nov 26, 2017 at 1:28 AM Lukas Winkler notifications@github.com wrote:
Hi, Many thanks for adding a new icon. 🎉 Just a few notes (as I haven't had time to write down how exactly I am structuring everything):
- As the text is often quite unreadable at small sizes ( https://raw.githubusercontent.com/piwik/piwik-icons/9a617c60bf03176d3da7c33ee778573a9c37cabe/src/brand/Danew.png) I often crop it away and just keep the characteristic symbol
- square is just a rule of thumb, as my converter script cuts all white space away and then places the icon on a square
- It would be really nice if you could add the exact URL to the file in the .source file.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/piwik/piwik-icons/pull/17#issuecomment-346992467, or mute the thread https://github.com/notifications/unsubscribe-auth/ACp8QzAqzsVd8w91BHBhowppb8EsYX3Dks5s6SE4gaJpZM4Qqri6 .
Merged in #18
btw added 1 pixel to make it square