search

matomo-org / matomo-icons

Source files for the icons in Matomo
22 stars 16 forks source link

Fix transparency issue in all Opera browser icons #22

Closed ghost closed 4 years ago

ghost commented 4 years ago

@Findus23 This pull request updates the current Opera browser icons, which all have unwanted whitespace in them, to be fully transparent. You can see the difference by opening the example images below in a new tab.

The new browser icons are all sourced from https://github.com/alrra/browser-logos.

Current icon OH

New icon OH

Edit: Here's also a screenshot from Matomo v3.14.1 showing the current icon's whitespace issue:

icon

Findus23 commented 4 years ago

Hi,

Many thanks for noticing the issue.

Unfortunately fixing it is a bit more complicated. I use a bash script to automatically (and reproducibly) convert the images from the src/ directory (which in this case is a symlink to the opera logos from https://github.com/alrra/browser-logos) using imagemagic.

But for whatever weird reason, when you add e.g. a green border to the logo using 

convert opera.png -bordercolor green -border 1x1 out.png

it replaces all existing transparency with green.

I fixed this now in https://github.com/matomo-org/matomo-icons/commit/f85567c0a2da3cf023cea10d7af53e229ce20c47 which should not only fix the opera icons, but a lot of others too. grafik

ghost commented 3 years ago

@Findus23 Just wanted to confirm that the issue is fixed in Matomo 4.0+. Thanks! 👍