matomo-org / matomo-java-tracker

Official Java implementation of the Matomo Tracking HTTP API.
https://matomo-org.github.io/matomo-java-tracker/
BSD 3-Clause "New" or "Revised" License
69 stars 52 forks source link

Remove 8 unnecessary stubbings in PiwikTrackerTest.java #138

Closed ARUS2023 closed 1 year ago

ARUS2023 commented 1 year ago

In our analysis of the project, we observed that there are 6 tests: PiwikTrackerTest.testSendBulkRequestAsync_Iterable, PiwikTrackerTest.testSendBulkRequestAsync_Iterable_StringFF, PiwikTrackerTest.testSendBulkRequestAsync_Iterable_StringFT, PiwikTrackerTest.testSendBulkRequestAsync_Iterable_StringTT, PiwikTrackerTest.testSendBulkRequest_Iterable_StringTT, PiwikTrackerTest.testSendRequestAsync contain 8 unnecessary stubbings in total.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

dheid commented 1 year ago

Thanks, @ARUS2023 !