search

matomo-org / matomo-java-tracker

Official Java implementation of the Matomo Tracking HTTP API.
https://matomo-org.github.io/matomo-java-tracker/
BSD 3-Clause "New" or "Revised" License
69 stars 52 forks source link

Support callback in async send methods #55

Closed ssaarinen closed 3 years ago

ssaarinen commented 3 years ago

Using MatomoTracker#sendRequestAsync method there is no easy way for caller to know if the call succeeds other than calling response.get(...) that causes calling thread to block and makes it effectivelly same as sendRequest.

Consider allowing clients to pass callback to HttpAsyncClient execute from MatomoTracker#sendRequestAsync et. al.

tholu commented 3 years ago

@ssaarinen Can you provide a Pull request for that?

ssaarinen commented 3 years ago

If the PR (#56) is fine could you maybe consider releasing the 1.7 version including it in the near future :) ?

tholu commented 3 years ago

@ssaarinen Thanks, I have merged it now and will prepare the 1.7 version next.

tholu commented 3 years ago

@ssaarinen v1.7 is on its way to Maven Central and I tagged a release: https://github.com/matomo-org/matomo-java-tracker/releases/tag/v1.7