search

matomo-org / matomo-nginx

Nginx configuration for running Matomo
406 stars 121 forks source link

Update matomo.conf #60

Closed flip111 closed 4 years ago

flip111 commented 4 years ago
  1. By default this line is included in the fastcgi snippet
  2. Current it talks about "uncommenting" a line which already doesn't have a comment
Findus23 commented 4 years ago

Hi,

  1. The uncomment mixup has already been fixed in https://github.com/matomo-org/matomo-nginx/pull/59

  2. While it is possible that the line is already in your config (it is for me on Debian), it is not in https://github.com/nginx/nginx/blob/master/conf/fastcgi.conf which I'd consider the canonical version. Also I prefer to err on the side of security in this case.
flip111 commented 4 years ago

Ok reasonable choices