search

matomo-org / matomo-sdk-android

SDK for Android to measure your apps with Matomo. Works on Android phones, tablets, Fire TV sticks, and more!
BSD 3-Clause "New" or "Revised" License
393 stars 164 forks source link

Crash if SSL unavailable #180

Closed d4rken closed 6 years ago

d4rken commented 6 years ago 
java.lang.IllegalArgumentException: protocol SSLv3 is not supported
        at com.android.org.conscrypt.NativeCrypto.checkEnabledProtocols(NativeCrypto.java:852)
        at com.android.org.conscrypt.OpenSSLSocketImpl.setEnabledProtocols(OpenSSLSocketImpl.java:806)
        at com.android.okhttp.internal.Platform.supportTlsIntolerantServer(Platform.java:75)
        at com.android.okhttp.Connection.upgradeToTls(Connection.java:137)
        at com.android.okhttp.Connection.connect(Connection.java:107)
        at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
        at com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
        at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
        at com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
        at com.android.okhttp.internal.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:296)
        at com.android.okhttp.internal.http.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:503)
        at com.android.okhttp.internal.http.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:136)
        at org.piwik.sdk.a.b.a(Dispatcher.java:256)
        at org.piwik.sdk.a.b$1.run(Dispatcher.java:167)
        at java.lang.Thread.run(Thread.java:841)
d4rken commented 6 years ago

implementation 'org.piwik.sdk:piwik-sdk:2.0.0'

d4rken commented 6 years ago

Nvm, already fixed in dev.

https://github.com/piwik/piwik-sdk-android/blob/dev/piwik-sdk/src/main/java/org/piwik/sdk/dispatcher/DefaultPacketSender.java#L57