search

matomo-org / matomo-sdk-android

SDK for Android to measure your apps with Matomo. Works on Android phones, tablets, Fire TV sticks, and more!
BSD 3-Clause "New" or "Revised" License
393 stars 164 forks source link

there is no logs for release apk #184

Closed fetchingly closed 6 years ago

fetchingly commented 6 years ago

the piwik service has no data for the release APK,but debug APK has

d4rken commented 6 years ago

I don't know what you mean by that.

d4rken commented 6 years ago

We use Timber for logging, see: https://github.com/JakeWharton/timber

Logging example: https://github.com/piwik/piwik-sdk-android/blob/c081b54efb5048caa3636fe3a06c0726ff991a73/exampleapp/src/main/java/com/piwik/demo/DemoApp.java#L39

PattaFeuFeu commented 6 years ago

@d4rken By switching from compile to implementation for Timber—as opposed to using api—, Timber no longer gets included as a library that can be used by consumers of the SDK. So not even the DemoApp would work. Are you planning on changing that or should I import Timber in addition to the SDK in order to be able to use the Timber.plant(new Timber.DebugTree()); statement?

d4rken commented 6 years ago

I'm not sure yet, I think a case could be made for both.

In any case it doesn't hurt if you manually include it for the time being.