search

matomo-org / matomo-sdk-android

SDK for Android to measure your apps with Matomo. Works on Android phones, tablets, Fire TV sticks, and more!
BSD 3-Clause "New" or "Revised" License
390 stars 162 forks source link

Fix server side device fingerprinting failing in edge cases. #319

Closed d4rken closed 3 years ago

d4rken commented 3 years ago

Continuation of #310 Inject device infos for fingerprinting into every packet.

d4rken commented 3 years ago

@kevinslashslash what do you think?

codecov-commenter commented 3 years ago

Codecov Report

Merging #319 (3da803e) into master (b20e8ef) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #319      +/-   ##
============================================
- Coverage     86.39%   86.38%   -0.01%     
+ Complexity      375      372       -3     
============================================
  Files            33       33              
  Lines          1426     1425       -1     
  Branches        168      167       -1     
============================================
- Hits           1232     1231       -1     
- Misses          122      123       +1     
+ Partials         72       71       -1
Impacted Files Coverage Δ
tracker/src/main/java/org/matomo/sdk/Tracker.java 93.29% <100.00%> (+0.51%) :arrow_up:
...a/org/matomo/sdk/dispatcher/DefaultDispatcher.java 93.27% <0.00%> (-0.85%) :arrow_down:
...er/src/main/java/org/matomo/sdk/tools/Objects.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b20e8ef...3da803e. Read the comment docs.

kevinslashslash commented 3 years ago

LGTM