Closed hannesa2 closed 2 years ago
Merging #334 (9ed41d7) into master (37d78d7) will increase coverage by
0.07%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #334 +/- ##
============================================
+ Coverage 86.78% 86.85% +0.07%
- Complexity 371 372 +1
============================================
Files 33 33
Lines 1415 1415
Branches 165 165
============================================
+ Hits 1228 1229 +1
Misses 117 117
+ Partials 70 69 -1
Impacted Files | Coverage Δ | |
---|---|---|
...a/org/matomo/sdk/dispatcher/DefaultDispatcher.java | 94.11% <0.00%> (+0.84%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 37d78d7...9ed41d7. Read the comment docs.
Something like https://github.com/matomo-org/matomo/pull/17809 might also be useful here
Because I want to test it, I introduce a pre-release ability
Because I want to test it, I introduce a pre-release ability
Pre-relase is working, but changelog not
I made a test release https://github.com/hannesa2/matomo-sdk-android/releases in my fork, and there at least, it was working
Does it only work for master maybe?
No, it works on a branch as well. Even pull request with merge commit and pull request with rebased commit.
Here are my tests https://github.com/hannesa2/matomo-sdk-android/releases
I've no clue, why the tests in this repository where without changelog. Maybe merge it and lighten a candle that next time on real release it will work on this repo as well ?
I removed the pre-release because it can't show tag in caption
Now it works like this gain. But without the pre-release ability
Please see my tests https://github.com/hannesa2/matomo-sdk-android/releases
A new release needs now only a new tag, eg
Then the release pipeline starts and generates a changelog, depended on labels of pull request. This means a label on pull request makes sense now, if you want to see it in release changelog,
All is untested and copy&paste from https://github.com/MikeOrtiz/TouchImageView where it works like this