matomo-org / matomo-sdk-android

SDK for Android to measure your apps with Matomo. Works on Android phones, tablets, Fire TV sticks, and more!
BSD 3-Clause "New" or "Revised" License
387 stars 163 forks source link

Changelog created by github #359

Closed hannesa2 closed 1 year ago

hannesa2 commented 1 year ago

https://github.com/softprops/action-gh-release/releases/tag/v0.1.14

Here you can see a sample https://github.com/hannesa2/paho.mqtt.android/releases/tag/3.6.0-beta1

d4rken commented 1 year ago

That looks really nice, cool ❤️

https://github.com/d4rken/android-starter-v4/releases/tag/v4.4.1

I love that it adds the little contributor icons to the bottom an mentions who authored a PR 🍻

hannesa2 commented 1 year ago

This should here no more necessary

image

Btw, I vote to remove the v from the git tag

hannesa2 commented 1 year ago

Btw, you already tested it, please can you test it with @v1 again ?

    uses: softprops/action-gh-release@v1

I'm not sure about the versioning there, and dependabot will make this pull request soon but the test needs to be done manually

d4rken commented 1 year ago

This should here no more necessary

Not for the changelog but I like to keep it in sync (even for my demo project 😁).

Btw, you already tested it, please can you test it with @v1 again ?

Will do.

Btw, I vote to remove the v from the git tag

I like that you can filter things like release creation v* and keeping it the same as it is might be easier for existing users. But I don't feel too strongly about it, if this is important for you feel free to change it ☕

d4rken commented 1 year ago

Looks okay with @v1 too https://github.com/d4rken/android-starter-v4/releases/tag/v4.4.1-rc1