search

matomo-org / matomo-sdk-android

SDK for Android to measure your apps with Matomo. Works on Android phones, tablets, Fire TV sticks, and more!
BSD 3-Clause "New" or "Revised" License
388 stars 162 forks source link

Send packet only with POST method. #470

Open nostromoo opened 8 months ago

nostromoo commented 8 months ago

Closes #468

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a6a7260) 87.12% compared to head (72de688) 86.99%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #470 +/- ## ============================================ - Coverage 87.12% 86.99% -0.14% + Complexity 364 358 -6 ============================================ Files 32 32 Lines 1429 1422 -7 Branches 165 162 -3 ============================================ - Hits 1245 1237 -8 - Misses 115 116 +1 Partials 69 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hannesa2 commented 8 months ago

@nostromoo Please test it first implementation 'com.github.nostromoo:matomo-sdk-android:remove_get_packet-SNAPSHOT' if it comes now with desired behavior. If yes, I'll merge it.

Please keep me informed

d4rken commented 8 months ago

Now I see the linked #468.

Did something change on the server-side? According to docs (the last time I checked) the server should accept both GET and POST. :shrug:

This could warrant further debugging to find out why GET is not working. Broken in the SDK? Or an issue with the server config?

If it's the later, changing the SDK seems like the wrong way to fix it :grin:.

hannesa2 commented 8 months ago

Now I see the linked #468.

I did it

hannesa2 commented 7 months ago

If it's the later, changing the SDK seems like the wrong way to fix it 😁.

Any suggestion what's the right way

d4rken commented 7 months ago

If it's the later, changing the SDK seems like the wrong way to fix it 😁.

Any suggestion what's the right way

Check if single GET requests are reaching the server, and if they are, check why the server is not processing them. Removing the GET and only using POST is fine, but shouldn't be done as a "guess" without understanding why GET is not working.

@mattab Did the server's behavior for GET change?