search

matomo-org / matomo-sdk-android

SDK for Android to measure your apps with Matomo. Works on Android phones, tablets, Fire TV sticks, and more!
BSD 3-Clause "New" or "Revised" License
386 stars 163 forks source link

Avoid clearing dispatcher when user changes optOut setting #476

Closed lorenc-tomasz closed 4 months ago

lorenc-tomasz commented 4 months ago

PR fixes #474

Basically setting setting setOptOut always clears dispatcher. It should set only flag and events should be omitted, not cleared.

hannesa2 commented 4 months ago

The tests are good, but they need an adaption too

lorenc-tomasz commented 4 months ago

Fixed. Sorry for that.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3eaf203) 87.12% compared to head (724c912) 87.11%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #476 +/- ## ============================================ - Coverage 87.12% 87.11% -0.01% Complexity 364 364 ============================================ Files 32 32 Lines 1429 1428 -1 Branches 165 165 ============================================ - Hits 1245 1244 -1 Misses 115 115 Partials 69 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hannesa2 commented 4 months ago

https://github.com/matomo-org/matomo-sdk-android/releases/tag/4.2