search

matomo-org / matomo-sdk-ios

Matomo iOS, tvOS and macOS SDK: a Matomo tracker written in Swift
MIT License
388 stars 164 forks source link

See screen sizes in piwik backend #149

Closed thorstenstark closed 7 years ago

thorstenstark commented 7 years ago

I think it would be useful to see the screen size of the tracked devices in the piwik backend. Currently there is only one screen size called "unknown".

brototyp commented 7 years ago

That is an easy thing to implement. In this document the res parameter is described as: The resolution of the device the visitor is using, eg 1280x1024.

I think it is save to say that that the resolution of a device never changes so we don't need to save the resolution for every event, but rather send it along. I think the best thing would be to have them as properties of the Event struct but don't implement them with the need to set it externally. Something like let screenSize = Device.makeCurrentDevice().screenSize. The other thing then would be to encode the size in the Events queryItems which encodes an event into an array of URLQueryItem.

akshaykolte commented 7 years ago

Assign this to me. I'll try working on it over the week.

brototyp commented 7 years ago

There is no need to assign issues. I am looking forward to you pull request. If you want to bounce ideas back and fourth just let me know.

akshaykolte commented 7 years ago

Can you let me know how to test the app, I pulled upstream from develop. The build succeeds, but the tests dont work. Do I need to change targets in project settings? How do I know if I add a parameter to to the Event struct is reflecting while creating the url for the server.

Thanks.

On Mon, Jun 5, 2017 at 11:57 AM, Cornelius Horstmann < notifications@github.com> wrote:

There is no need to assign issues. I am looking forward to you pull request. If you want to bounce ideas back and fourth just let me know.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/piwik/piwik-sdk-ios/issues/149#issuecomment-306113395, or mute the thread https://github.com/notifications/unsubscribe-auth/AGg5M4QxVwoaB6RBb-XlMcM-sfg9JyfOks5sA5-2gaJpZM4NpCUf .

akshaykolte commented 7 years ago

Got my tests to run. Had an issue with pods. Made change in Tests. A file was using Tracker instead of PiwikTracker. Tests ran successfully. Still can run the Example.

brototyp commented 7 years ago

Hi @akshaykolte thank you for your PR. I just checked about the Example application. There is the same issue like in the Tests. It's a merge issue. The example application should work, if you edit the OptOutViewController.swift and replace all Tracker with PiwikTracker. Sorry for that!