search

matomo-org / matomo-sdk-ios

Matomo iOS, tvOS and macOS SDK: a Matomo tracker written in Swift
MIT License
388 stars 164 forks source link

Can't install with Carthage. #190

Closed thbaja closed 7 years ago

thbaja commented 7 years ago

When trying to install via Carthage I encounter this:

> carthage update
*** Fetching piwik-sdk-ios
*** Checking out piwik-sdk-ios at "v4.2.0"
Parse error: expected submodule commit SHA in output of task (ls-tree -z v4.2.0 AFNetworking) but encountered:

Cartfile: github "piwik/piwik-sdk-ios"

brototyp commented 7 years ago

Hi @thbaja, thanks for the report. Is there more information after the encountered:?

thbaja commented 7 years ago

No, unfortunately not. It seems that submodules can sometimes cause issues: https://github.com/Carthage/Carthage/issues/135

brototyp commented 7 years ago

Hi @thbaja, that was a good point. There was an old Submodule configured in the repository. I just deleted it and released it along with version 4.3.

elitalon commented 7 years ago

@thbaja Did this happen because you also had AFNetworking as a dependency or it just happens in general when installing piwik-sdk-ios with Carthage? The latter should've been caught when running build_with_package_manager in the CI 🤔

brototyp commented 7 years ago

@elitalon I tested this issue yesterday by creating a new, empty Xcode project and adding the github "piwik/piwik-sdk-ios" to a Cartfile. So no other dependencies were necessary. Is this possibly an issue with just Xcode 9?

brototyp commented 7 years ago

I just checked. Travis is testing on Xcode 9, so it can't be it.