matomo-org / matomo-sdk-ios

Matomo iOS, tvOS and macOS SDK: a Matomo tracker written in Swift
MIT License
388 stars 164 forks source link

Removed the url as required parameter #195

Closed brototyp closed 7 years ago

brototyp commented 7 years ago

Fixes/Implements #194

What changed:

Do we want to add a way to generate a default url? If so, this would be my proposal:

Example:

thbaja commented 7 years ago

I think this is a good PR.

And a very good proposal regarding the contentBaseUrl. Perhaps this should also apply for when tracking screens?

brototyp commented 7 years ago

Yes, I would apply the logic to all events that are tracked. It is a bit complicated to differentiate between an event and an Event where the latter includes events, screen views and all other kind of data send to the backend.

thbaja commented 7 years ago

Understood 👍

brototyp commented 7 years ago

Just released version 4.4.0 containing this change.