Feature/fix swift header warnings and use correct access levels

matomo-org / matomo-sdk-ios

Matomo iOS, tvOS and macOS SDK: a Matomo tracker written in Swift

MIT License

388 stars 164 forks source link

Feature/fix swift header warnings and use correct access levels #222

Closed mattmoncur closed 6 years ago

mattmoncur commented 6 years ago

fix swift header warnings in PiwikTracker.swift
use correct access levels in Application.swift and Device.swift extensions

brototyp commented 6 years ago

Hi @mattmoncur, thanks for you effort. Unfortunately I cannot see the warnings in the PiwikTracker.swift. When are they occurring?

mattmoncur commented 6 years ago

@brototyp I was including PiwikTracker's source file directly in my project, and my auto generated Project-Swift.h header had the warnings. Xcode 9.2.

brototyp commented 6 years ago

Hi @mattmoncur, I see. I think your project uses Swift 3.2 or such. This project is using Swift version 4.0 Is it possible, that's the reason for your issues?

brototyp commented 6 years ago

I will close this for now. Please get back in touch with me if you think I am wrong.

mattmoncur commented 6 years ago

Sorry yes that was it, it also looks like your correct the siteID siteId mismatch in MatomoTracker.swift. Cheers -Matt

brototyp commented 6 years ago

Thanks for your feedback and thanks for the effort of creating a PR.