search

matomo-org / matomo-sdk-ios

Matomo iOS, tvOS and macOS SDK: a Matomo tracker written in Swift
MIT License
388 stars 164 forks source link

Support for Swift 5.0 and Xcode 10.2 #291

Closed joaomvfsantos closed 5 years ago

joaomvfsantos commented 5 years ago

What I did:

brototyp-bot commented 5 years ago
1 Warning
:warning: Are there any changes that should be explained in the README.md?

Generated by :no_entry_sign: Danger

brototyp commented 5 years ago

Hey @joaomvfsantos, thanks a lot for your PR and sorry I didn't respond yet. I'll try to check out what's going on with the build error there and get back here.

joaomvfsantos commented 5 years ago

Hey @brototyp no problem. Thanks for looking into that, I'm not familiar with Travis CI so I appreciate that.

brototyp commented 5 years ago

Hey @joaomvfsantos, I fixed the issue with the CI in #294 and merged to develop. If you rebase from develop it should build just right.

joaomvfsantos commented 5 years ago

@brototyp There seems to be something wrong still. --no-document is duplicated on the install step and CI is complaining about an invalid option --no-ri.

brototyp commented 5 years ago

Hey @joaomvfsantos, thanks for checking that out. I did a little more research (not the ruby pro here 😉) and I guess the following would help:

  1. Change in .travis.yml 
    before_install:
- 'echo ''gem: --no-ri --no-document'' > ~/.gemrc'

to

before_install:
  - 'echo ''gem: --no-document'' > ~/.gemrc'
  1. Change in .travis.yml 
    install:
- gem install cocoapods --no-document --no-ri --no-document --quiet
- gem install xcpretty --no-document --no-ri --no-document --quiet

to

install:
  - gem install cocoapods --no-document --quiet
  - gem install xcpretty --no-document --quiet

Can you try that out?

joaomvfsantos commented 5 years ago

Hey @brototyp, this did the trick, but now failing the tests for some reason on iOS 9. This also happens locally, I think that there must be some issue with Xcode 10.2, because it's not the tests themselves that are failing, but rather it fails right at the beginning. Could not figure this one out yet. Will try to give it a closer look.

brototyp commented 5 years ago

Hey @joaomvfsantos, thanks a lot for your effort on this PR here and that I wasn't to much of help there. Swift 5 Support was merged in #306 in the meantime. I'll close this PR for now.