search

matomo-org / matomo-sdk-ios

Matomo iOS, tvOS and macOS SDK: a Matomo tracker written in Swift
MIT License
388 stars 164 forks source link

Follow up from new custom action parameters #363

Closed tsteur closed 3 years ago

tsteur commented 4 years ago

Follow up from https://github.com/matomo-org/matomo-sdk-ios/pull/355 and https://github.com/matomo-org/matomo-sdk-ios/issues/354

We just realised that this new ca=1 parameter should not be sent in goals and ecommerce tracking requests but only for events and optionally content tracking requests (if this is implemented).

If I understand the PR right this is already the case but wanted to double check to make sure &ca=1 is not sent for any goal tracking or ecommerce tracking request.

Cheers

brototyp commented 3 years ago

Hey @tsteur,

thanks for bringing this one in. I wanted to check back, to make sure we get it correct this time.

I am not sure if I clearly understand when the parameter should be sent and when it shouldn't. I am esp. curious about events we haven't implemented yet, e.g. media analytics and such.

As the documentation isn't really explicit about this: Is there a definition on when these events should be sent and when not? In this implementation everything is an event. A page view, an e-commerce tracking event, an action ...

Thanks a lot!

tsteur commented 3 years ago

Hi @brototyp in this case you basically only need to append it for an event tracking request. Not for any other kind of tracking requests.

brototyp commented 3 years ago

Thanks @tsteur This is released in v7.4