plugin activation/deactivation: keep/restore filter

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!

https://matomo.org/

GNU General Public License v3.0

19.8k stars 2.64k forks source link

plugin activation/deactivation: keep/restore filter #10624

Open hpvd opened 8 years ago

hpvd commented 8 years ago

When activating or deactivating a plugin one should keep/restore the filter applied before (e.g. 3rd part.) The reasons:

one could directly see if the thing one wants to do was successful
one may want to do some other things in same filter categorie

(this is lessons learned when wanting to deactivate all 3rd part. plugin for https://github.com/piwik/piwik/issues/10619#issuecomment-250933734)

mattab commented 8 years ago

Hi @hpvd - Thanks for suggestion. I assume by "should keep the filter applied before" you mean "Restore the 'third party plugins' filter (or another 'filter') as it was selected before activating the plugin"

hpvd commented 8 years ago

yes, maybe from technical site it's a "restore" :-)

hpvd commented 8 years ago

all types of filter should be restored:

origin
status