search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.83k stars 2.64k forks source link

When uploading a plugin, make sure files starting with a dot are unzipped #11716

Open tsteur opened 7 years ago

tsteur commented 7 years ago

I uploaded a plugin before in Piwik 3.0.4 and noticed a .htacces file was not in the plugin directory after installing it even though it was included in the zip.

We need to try and reproduce this again and if needed fix it.

sgiehl commented 7 years ago

According to various reports on the internet ZipArchive::extractTo is not able to extract hidden files on linux. Wouldn't it be a possibility to create the file up on install of the plugin within the PHP code?

tsteur commented 7 years ago

creating it now on install and activate. Will also be needed to be done on plugin update which I still need to add. If it is not possible to fix we need to document it somewhere I reckon

mattab commented 7 years ago

maybe we should move to a pure php solution which would let us extract all files? eg https://stackoverflow.com/a/43016122