search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.68k stars 2.62k forks source link

Page Overlay broke when jQuery loaded in site #11874

Closed xyb closed 7 years ago

xyb commented 7 years ago

Page Overlay failed when my web site using jQuery, and web console have error messages:

followingpages.js?v=1:333
Uncaught TypeError: linkTag.children(...).size is not a function
    at checkHasOneChild (followingpages.js?v=1:333)
    at positionLinkTags (followingpages.js?v=1:228)
    at build (followingpages.js?v=1:118)
    at followingpages.js?v=1:517
    at followingpages.js?v=1:53
    at Object.success (client.js?v=1:163)
    at i (jquery-3.1.0.min.js:2)
    at Object.fireWith [as resolveWith] (jquery-3.1.0.min.js:2)
    at A (jquery-3.1.0.min.js:4)
    at HTMLScriptElement.c (jquery-3.1.0.min.js:4)

see also https://forum.piwik.org/t/page-overlay-broke-when-jquery-loaded-in-site/23901

sgiehl commented 7 years ago

The merged PR will solve this special failure, but I guess there might occur other problems depending on the jQuery version the overlayed site is using. If any other errors occur somewhere, please open new issues.