search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.92k stars 2.66k forks source link

Maintenance mode still accepts tracking requests #13797

Open tsteur opened 5 years ago

tsteur commented 5 years ago

This looks like a bug. When maintenance mode is enabled, it should also block all requests to the PHP tracker API and not process any tracking requests. This is eg useful when having a long running ALTER TABLE query running and at the same time heaps of other requests are still coming in.

tsteur commented 5 years ago

Turns out there is

[Tracker]
record_statistics=0
tsteur commented 5 years ago

Or ideally, when maintenance_mode=1, it would assume record_statistics=0. so maintenance mode would disable UI and tracking requests. Then we could have maybe a setting to only enable maintenance_mode_ui. Wondering also if in same process record_statistics could be eventually renamed to maintenance_mode_tracker or just have it as an additional flag besides record_statistics for usability.