search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.83k stars 2.64k forks source link

Row evolution not working in several reports #17263

Open eramirezprotec opened 3 years ago

eramirezprotec commented 3 years ago

Expected Behavior

When clicking on a row evolution icon, I should be able to see correctly the evolution of the row data:

image image

Current Behavior

Three different errors are occurring:

  1. [Reproducible in demo.matomo.cloud] Matomo completely breaks, throwing the following error: image In my local environment, looks like this: image
  2. [Reproducible in demo.matomo.cloud] The graphic shows itself empty: image
  3. [Couldn't reproduce in demo.matomo.cloud] After closing the empty graphic from the previous step, another graphic is automatically opened; this time, with data: image image image

Possible Solution

Based on this information:

Call to undefined method Piwik\DataTable\Map::getRows() in C:\xampp\htdocs\piwik\updated-version\plugins\CustomDimensions\API.php line 66

We get to:

image

The problem described in the first point of the previous section, appears when the hit from JS includes the parameter idSubtable. Another difference between the hits is the presence of the paramater flat with value 0.

Good request: image

Bad request: image

Another important thing happening is that the method getCustomDimension is being called several times when processing the request; the last execution of it, receives the parameter $date with a range of dates (2021-02-05,2021-02-15, for instance); when this happens and the parameter idSubtable is present, the method Archive::createDataTableFromArchive is executed and it does not return a DataTable, reason why we get the error described before.

By avoiding the execution of the method Archive::createDataTableFromArchive, the first error disapears, but the second and third one continue happening.

Steps to Reproduce (for Bugs)

1.Enter to demo.matomo.cloud 2.Enter to Behaviour->Page Author 3.Expand any row and click on the Open Row Evolution icon of one of the subtable rows 4.Close the dialog using the X button 5.Click on the Open Row Evolution icon of another of the subtable rows 6.If the error does not appear, try the previous step but with a register of another subtable

About the second error, repeat the same steps but using the Acquisition->Websites section.

The third error appears jointly with the second one. Although, I couldn't reproduce it in demo.matomo.cloud.

Context

Related issues:

Your Environment

CC: @pardvm

diosmosis commented 3 years ago

Seems to happen only some subtable rows. Here's a link to one failure: https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=yesterday&segment=&category=General_Actions&subcategory=customdimension2&popover=RowAction$3ARowEvolution$3ACustomDimensions.getCustomDimension$3A$257B$2522idDimension$2522$253A$25222$2522$252C$2522idSubtable$2522$253A$25222$2522$257D$3Aadmindz$20$3E$20$40divezone.net$252Fjobs

sgiehl commented 3 years ago

@diosmosis Might be related to our discussion in https://github.com/matomo-org/plugin-MarketingCampaignsReporting/pull/62

ElLorans commented 1 year ago

I have the same issue. The only solution is to collapse all rows, which is not enough. I looked into https://github.com/matomo-org/matomo/issues/17374 and https://github.com/matomo-org/matomo/issues/17374 to no avail. EDIT: oddly enough, I experience the empty graph only in widgets, but it works from matomo cloud.

Stan-vw commented 1 year ago

I was able to reproduce this last month but I tried it again today on a few environments and it seems to work like a charm. Closing it for now, but we can reopen in case someone experiences it again. Would be great to understand what the way to reproduce is in case we can reproduce it again.

heurteph-ei commented 1 year ago

Very strange: When you click on the @diosmosis link the graph is empty, but if you close the graph and reopen it manually (admindz > http://divezone.net/jobs), data are there... đŸ¤”