search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.67k stars 2.62k forks source link

Add more plugins as submodules #18256

Open tsteur opened 2 years ago

tsteur commented 2 years ago

We just noticed that there are few plugins missing as submodules:

Can/should we add these as submodules maybe too to ensure we notice when we break these plugins? Not sure if it would cause tests to go a lot longer. Some of them also don't have tests.

Some of them are under the InnoCraft user. I suppose we could still add them? Or maybe otherwise move them to matomo-org if that be an issue?

sgiehl commented 2 years ago

All plugins having tests should actually always run their tests against latest 4.x-dev branch. Imho it might be enough to run those tests regularly to ensure nothing breaks. Checking those builds before a release of Matomo might actually be enough.

tsteur commented 2 years ago

@sgiehl are you saying we should remove all plugin submodules?

sgiehl commented 2 years ago

Not all. The only benefit I see on having the submodules is that we might be able to identify potential issues that might occur when plugin are available prior to installation or their code is updated together with core. See my last PRs in AnonymousTracking plugin. But those issues should be rare and unlikely and not worth the effort.

Btw Removing the submodules would mean updating a lot tests. But if we have set up a good process to check all plugins before we release a new version of Matomo we could probably do that. For now it might be easier not to do that.