search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.36k stars 2.59k forks source link

Matomo 4.6.0 update causes integrity check error #18412

Closed MichaIng closed 2 years ago

MichaIng commented 2 years ago 
Files were found in your Matomo, but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: vendor/lox/xhprof/bin/xhprofile

This already happened at least on last RC version.

Expected Behavior

If there were no integrity check errors before an update, there shouldn't be any after an update.

Current Behavior

Update to Matomo 4.6.0 creates vendor/lox/xhprof/bin/xhprofile which violates the integrity check.

Possible Solution

Remove this file from the update archive.

Steps to Reproduce (for Bugs)

  1. Start with any Matomo <4.6.0
  2. Verify that there are no integrity check errors, else fix them
  3. Update to Matomo 4.6.0
  4. Check for integrity check errors

Context

Your Environment

DBX12 commented 2 years ago

I'm seeing this as well. Additionally, I got some more files highlighted by the integrity check

Files were found in your Matomo, but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: misc/composer/build-xhprof.sh
File to delete: misc/composer/clean-xhprof.sh
File to delete: vendor/lox/xhprof/bin/xhprofile
File to delete: node_modules/jquery.dotdotdot/.npmignore

While the first two seem like build dependencies and could potentially be deleted, the third one looks definitely like a wanted file to me. That .npmignore is probably unproblematic to delete.

MichaIng commented 2 years ago

At least the latest update does not ship the other three files, but probably they were shipped with Matomo 4.5 already? I remember seeing integrity check errors more regularly after updates, but I didn't report them every time when faced during beta or RC updates. Now it is however a stable release and that additional file was definitely shipped with the v4.6.0 stable update since I removed the same file before on v4.6.0-rc2.

tsteur commented 2 years ago

Thanks for this @MichaIng . I'll mark this as a duplicate of https://github.com/matomo-org/matomo/issues/18415 we will look into this soon and I think we'll release a 4.6.1 where this will be fixed.