search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.65k stars 2.62k forks source link

AdblockIsMaybeUsed warning refers to Matomo directly, breaking WhiteLabel #19688

Open vigilyn opened 2 years ago

vigilyn commented 2 years ago

The Adblock Warning in the language files "AdblockIsMaybeUsed" should refer to whatever the custom brand/product name is set to and not "Matomo" directly.

Here is the link to the English version: https://github.com/matomo-org/matomo/blob/2b35b46a0988f8c3b6f848c59be8d7d918965a52/plugins/CoreHome/lang/en.json#L98

sgiehl commented 2 years ago

@vigilyn You are referring to the premium plugin "Whitelabel", right? I'm not sure if that needs to be changed in core, or if the plugin has an issue. @AltamashShaikh Do you know this issue or can maybe say something on it? If it's something that needs to be fixed in the plugin, we should maybe create an internal issue for it and close the issue here. Or does this require changes in core?