search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.65k stars 2.62k forks source link

X o'clock UTC >> XX:00 UTC #21118

Open Stan-vw opened 1 year ago

Stan-vw commented 1 year ago

Summary

"X o'clock" is very informal and not very clear, since it's not a common pattern to show time. I'd suggest changing it to the more common pattern "XX:00 UTC" (of course including any time conversions that we use) image

Your Environment

sgiehl commented 1 year ago

The proper solution for this one, would be to import that correct format from intl, and show the hour:minute format depending on the user settings as 12 or 24 hours version. Related code places to change/extend: https://github.com/matomo-org/matomo/blob/62ea1e27c8d03ed64342b26361ade7c424747aaf/plugins/Intl/Commands/GenerateIntl.php#L385-L388 https://github.com/matomo-org/matomo/blob/593437a3fd35381c13fe5cf7fabae5767dc3a519/plugins/Intl/DateTimeFormatProvider.php#L107-L118 https://github.com/matomo-org/matomo/blob/f23c38f2f768558ee11f74a1695aa4f2ebf0f6ea/plugins/ScheduledReports/vue/src/AddReport/AddReport.vue#L507-L513