matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.92k stars 2.66k forks source link

Allow for marketplace provided plugin cover images #21879

Closed michalkleiner closed 9 months ago

michalkleiner commented 9 months ago

Description:

The change in this PR allows for use of cover images provided by the plugins marketplace while keeping the existing fallback images for Matomo vs 3rd party plugins.

The PR:

There is also a follow-up draft PR #21915 which should be merged once the corresponding changes to the marketplace have been deployed so that the test there can pass.

ref. DEV-17378

Review

michalkleiner commented 9 months ago

Failure for Piwik\Plugins\Marketplace\tests\System\Api\ClientTest::test_getPluginInfo_existingPluginOnTheMarketplace within the SystemTestsPlugins suites (for all 3 PHP versions) is expected until a corresponding change providing the category and coverImage fields is deployed to the marketplace.

I'd be happy to remove the change to the test and add it back after the marketplace change is deployed to production if that's preferred.

UPDATE: Discussed in person with MC and will move this to a separate PR that can be merged once the corresponding change is deployed to Marketplace PROD.

UPDATE 2: Moved to PR #21915

michalkleiner commented 9 months ago

This change can be reviewed, merged and released independently of the marketplace changes as it provides defaults for the category and cover image in the same way how it worked before.

michalkleiner commented 9 months ago

Thanks @sgiehl. I know we don't want dead code that won't be used though I'm confident this will get through at the Marketplace end as well. Also, the change surface here is quite contained, so I think this can be merged. If we need to adjust anything I can follow up on that.