[Bug] Disabling Goals Plugin cases error when opening Visitor Profile popup

sschueller commented 6 months ago

What happened?

When you disable the goals plugin an error will occur when opening a "Visitor Profile".

Error: The plugin Goals is not enabled. You can activate the plugin on Settings > Plugins page in Matomo.

What should happen?

Visitor Profile should open without an error or if there is no possibility to show this the button to open the profile should not be visible.

How can this be reproduced?

Copy all 3 files: https://github.com/matomo-org/docker/tree/master/.examples/nginx
Set DB password in docker-compose.yml and db.env to be the same
Start the stack with docker-compose up
Follow installation at http://localhost:8080
Enable dev mode docker exec -it matomo_test-app-1 vi config/config.ini.php add:
```
[Development]
enabled = 1
```

Add fake page to generate traffic. docker exec -it matomo_test-app-1 vi test.html

<html>
<head></head>
<body>
test
<!-- Matomo -->
<script>
var _paq = window._paq = window._paq || [];
/* tracker methods like "setCustomDimension" should be called before "trackPageView" */
_paq.push(['trackPageView']);
_paq.push(['enableLinkTracking']);
(function() {
var u="//localhost:8080/";
_paq.push(['setTrackerUrl', u+'matomo.php']);
_paq.push(['setSiteId', '1']);
var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s);
})();
</script>
<!-- End Matomo Code -->
</body>
</html>

Visit this page a few times to generate traffic: http://localhost:8080/test.html
Disable goals plugin
Click on any "View visitor Profile"

Matomo version

5.0.2

PHP version

8.2.15

Server operating system

matomo:fpm-alpine docker

What browsers are you seeing the problem on?

Firefox

Computer operating system

MacOS

Relevant log output

ERROR Live[2024-03-07 08:00:06 UTC] [3ca3f] Uncaught exception in API: /var/www/html/core/Plugin/Manager.php(303): The plugin Goals is not enabled. You can activate the plugin on Settings > Plugins page in Matomo. [Query: ?date=yesterday&module=Live&action=getVisitorProfilePopup&visitorId=518fc5298fe847d6&idSite=1&period=day, CLI mode: 0]
ERROR Piwik\ExceptionHandler[2024-03-07 08:00:06 UTC] [3ca3f] Uncaught exception: /var/www/html/core/Plugin/Manager.php(303): The plugin Goals is not enabled. You can activate the plugin on Settings > Plugins page in Matomo. [Query: ?date=yesterday&module=Live&action=getVisitorProfilePopup&visitorId=518fc5298fe847d6&idSite=1&period=day, CLI mode: 0]

Validations

[X] Read our Contributing Guidelines.
[X] Follow our Security Policy.
[X] Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
[X] The provided steps to reproduce is a minimal reproducible of the Bug.

sschueller commented 6 months ago

mneudert commented 6 months ago

Hi @sschueller, can confirm deactivating the Goals plugins breaks the visitor log on both 4.x and 5.x.

Will pass this on to the product team for prioritization.

Should be checked if there are any side effects, e.g. to ecommerce tracking, if we simply test for Goal plugin activation status in the relevant places (#1, #2, maybe more).

matomo-org / matomo