search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.19k stars 2.57k forks source link

Password field is disabled when saving settings [Bug] #22203

Closed jorgeuos closed 3 weeks ago

jorgeuos commented 3 weeks ago

What happened?

I've seen this a couple of times now, even with previous versions too.

The password field is disabled when trying to save General settings, which prompts for password.

Could be elsewhere too, e.g. the user setting page.

I believe it has to do with a Vue component setting isLoading or isUpdating to true and never sets it to false, I could be wrong.

What should happen?

It should be possible to input your password when prompted.

How can this be reproduced?

Go to the settings page, update a field, "Cross-Origin Resource Sharing (CORS) domains" for example, and hit save.

Matomo version

5.0.3

PHP version

8.2.18

Server operating system

No response

What browsers are you seeing the problem on?

Chrome

Computer operating system

No response

Relevant log output

No response

Validations

sgiehl commented 3 weeks ago

@jorgeuos are you using LoginLdap or LoginSaml? When using those plugins the password field might be disabled on purpose.

jorgeuos commented 3 weeks ago

Ah, that could be it. I believe SAML has recently been activated. Thanks!

sgiehl commented 3 weeks ago

Note: With Matomo 5.1.0. the password field will no longer be shown when it is not required. See https://github.com/matomo-org/matomo/pull/21916